From: Junio C Hamano <junkio@cox.net>
Date: Wed, 09 May 2007 07:13:17 GMT
Subject: Re: [PATCH v2] Custom compression levels for objects and packs
Message-ID: <7vd51axyeq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <56b7f5510705082346m32d3c48dj987fd9b0a6118c10@mail.gmail.com>

"Dana How" <danahow@gmail.com> writes:

> This doesn't interact well with each variable being processed
> completely independently in git_config() and the callbacks it calls.
> The isset() value is "out-of-band"; either store it in the _seen
> variables, or some special value in used_value .
>
> Which makes the most sense:
> * Leave _seen as-is;
> * Move pack.compression recognition into config.c which means
>  the _seen variables would all be local to config.c;
> * Use some special value, and if still present replace it with the default
>  at the end of git_config() using extra code;
> * Change the config rule to something simpler.
>
> I like the 2nd and the 4th.  You didn't like the 4th.
> Shall I change to the 2nd?

FWIW, I am Ok with (1).