From: Junio C Hamano <junkio@cox.net>
Date: Mon, 21 May 2007 03:15:12 GMT
Subject: Re: [PATCH] Teach mailsplit about Maildir's
Message-ID: <7vd50uj29r.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070520181447.GA10638@ferdyx.org>

"Fernando J. Pereda" <ferdy@gentoo.org> writes:

> -	ret = split_mbox(argp, dir, allow_bare, nr_prec, nr);
> +	while (*argp) {
> +		const char *arg = *argp++;
> +		struct stat argstat;
> +
> +		if (arg[0] == '-' && arg[1] == 0) {
> +			ret |= split_mbox(arg, dir, allow_bare, nr_prec, nr);
> +			continue;
> +		}
> +
> +		if (stat(arg, &argstat) == -1) {
> +			error("cannot stat %s (%s)", arg, strerror(errno));
> +			return 1;
> +		}
> +
> +		if (S_ISDIR(argstat.st_mode))
> +			ret |= split_maildir(arg, dir, nr_prec, nr);
> +		else
> +			ret |= split_mbox(arg, dir, allow_bare, nr_prec, nr);
> +	}
> +
>  	if (ret != -1)
>  		printf("%d\n", ret);
>  

No kidding.  ret |= stuff and then printf("%d\n", ret) would not
give us the number of commit e-mails on the standard output.