From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 09 Mar 2008 03:57:36 GMT
Subject: Re: [PATCH 08/11] Allow for having for_each_ref() list some refs that aren't local
Message-ID: <7vd4q4sg5r.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0803081804170.19665@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

> This is useful, for example, for listing the refs in a reference
> repository during clone, when you don't have your own refs that cover
> the objects that are in your alternate repository.

I hate to ask a question that I myself do not have a good answer to, but
it is a bit worrysome that using these extra refs would cause for-each-ref
to report different refs with the same name (the alternate's master branch
and this one's master branch are both called refs/heads/master).

I think no caller that reads from for_each_ref() keeps track of names that
it has seen and tries clever things like flagging duplicates as errors,
but it still feels like it is inviting trouble.