From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Jun 2008 22:55:47 GMT
Subject: Re: [PATCH] Introduce get_octopus_merge_bases() in commit.c
Message-ID: <7vd4mqfcb0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1213051426-11530-1-git-send-email-vmiklos@frugalware.org>

Miklos Vajna <vmiklos@frugalware.org> writes:

> Exactly. I modified merge_bases_many() to use a commit list.

I just looked at your f755fb6; from the point of view of merge_bases()
which is far more often used, I think this is not an improvement but
actively wrong thing to do.  Most of the time callers compute merge base
of two, and the codepath should be optimized for that case.