From: Junio C Hamano Date: Thu, 19 Jun 2008 19:21:00 GMT Subject: Re: [PATCH] Authentication support for pserver Message-ID: <7vd4mdten7.fsf@gitster.siamese.dyndns.org> In-Reply-To: <46a038f90806191200n237633u80f0be736e8d227b@mail.gmail.com> "Martin Langhoff" writes: > On Thu, Jun 19, 2008 at 1:38 PM, Ævar Arnfjörð Bjarmason wrote: >>> 1. http://git.nix.is/?p=avar/git;a=commitdiff;h=60f893bd9fe329bd5cf8ec513d10ec00e85feb2c >> >> It has been over 3 months since I submitted this patch without anyone >> acting on it. In absence of comment from the Mart[yi]ns could this >> please applied anyway? > > Sorry. My opinion on this is a mild ACK on the technical front, and a > bit of a frown ("do we really want to offer this?"). Specifically, my > concern goes beyond what you can do against a pserver service - git > hooks can be targeted with this. "Warning: as safe as telnet" ;-) "As safe as telnet" is Ok as long as it is strictly optional. What I would primarily be worried about is if this change is a no-op for existing users, when they chose not to enable the new feature.