From: Junio C Hamano Date: Sat, 07 Feb 2009 07:48:08 GMT Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match Message-ID: <7vd4duzo07.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200902061149.16210.jnareb@gmail.com> Jakub Narebski writes: > Make SHA-1 regexp to be turned into hyperlink (SHA-1 committag) > to match word boundary at beginning and end. This way we limit > false matches, for example 0x74a5cd01 which is hex decimal (for > example memory address) but not SHA-1. > > Also make sure that it is not Message-ID, which fragment just > looks like SHA-1 (e.g. "Message-ID: <46A0F335@example.com>"), > by using zero-width negative look-ahead assertion to _not_ > match '@' after. Your message I am responding to is: Message-ID: <200902061149.16210.jnareb@gmail.com> Does your description mean that "200902061149" would match, because the LAA will say "Ah, dot is not an at-sign"?