From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Oct 2009 18:06:50 GMT
Subject: Re: [PATCH] commit: More generous accepting of RFC-2822 footer lines.
Message-ID: <7vd447o0jp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091028171344.GA22290@quaoar.codeaurora.org>

David Brown <davidb@codeaurora.org> writes:

> From: David Brown <davidb@quicinc.com>
>
> 'git commit -s' will insert a blank line before the Signed-off-by
> line at the end of the message, unless this last line is a
> Signed-off-by line itself.  Common use has other trailing lines
> at the ends of commit text, in the style of RFC2822 headers.
>
> Be more generous in considering lines to be part of this footer.
> If the last paragraph of the commit message reasonably resembles
> RFC-2822 formatted lines, don't insert that blank line.

I do not think it is particularly readable to add Cc: at the end, and in a
sense this patch encourages that practice (without the patch, the end
result looks ugly and that has an effect to discourage people from adding
Cc: there).

But this is not a strong objection.  Applied.

Thanks.