From: Junio C Hamano Date: Fri, 12 Mar 2010 05:54:56 GMT Subject: Re: [PATCH] Do not strip empty lines / trailing spaces from a commit message template Message-ID: <7vd3zat77z.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100311224656.GA25553@sigill.intra.peff.net> Jeff King writes: > On Thu, Mar 11, 2010 at 12:46:51PM -0800, Junio C Hamano wrote: > >> > How about a test to check the new behavior? >> >> Speaking of tests, t2203 will segfault with your patch. I don't think the >> following does, though. > > I thought I ran the tests, but obviously not. I see the segfault here. > It is not just t2203, but any "git commit" with no message will cause > it. > > Your patch looks right, and is more readable, too, I think. Ok, Sebastian can use that code in his reroll with tests, then. Thanks.