From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Nov 2010 23:10:17 GMT
Subject: Re: [PATCHv7.2 1/4] gitweb: Prepare for splitting gitweb
Message-ID: <7vd3q3eecm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201011130041.22918.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> That means adding GITWEBLIBDIR for future testing of individual
> modules (it was not present in v7.1).

You confused me.  "git grep" after test-applying this 4-patch series on
top of next shows only one GITWEBLIBDIR, which means that the symbol is
defined but nobody pays attention to it.

> diff --git a/gitweb/Makefile b/gitweb/Makefile
> index 0a6ac00..f9e32eb 100644
> --- a/gitweb/Makefile
> +++ b/gitweb/Makefile
> @@ -57,6 +57,7 @@ PERL_PATH  ?= /usr/bin/perl
> ...
> -.PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
> +.PHONY: all clean install install-modules test test-installed .FORCE-GIT-VERSION-FILE FORCE
>  

In the earlier series, 478da52 (gitweb: Prepare for splitting gitweb,
2010-10-30) removed the trailing blank line from here but this does not do
so anymore, which is a micronit regression.