From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Apr 2011 16:18:08 GMT
Subject: Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support
Message-ID: <7vd3kyf327.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BANLkTint7sGCg7_seu1-SWJC=_sKF-FKYw@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> Also the patch does not catch this (ie. not die() on unrecognized signature).

Of course it doesn't.

I didn't say "everything that is not alphanumeric is magic". I only said
"all the magic are not alphanumeric".  Notice the difference.


This is so that you can say ":/.gitignore" and do not have to say
":/:.gitignore".

I am also tempted to special case a ':' followed by a zero magic as if it
specifies the top magic, e.g. ":Makefile" is the same as ":(top)Makefile",
aka ":/Makefile".  It is not in the published code, but the short-cut
would help ":.gitignore".

You don't require, nor allowed to have, a colon after ')' when writing a
long hand, by the way.  There is no reason to require one for disambiguation.