From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 24 Sep 2011 03:50:32 GMT
Subject: Re: [ANNOUNCE] Git 1.7.6.4
Message-ID: <7vd3eqsinr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4850EB43-5CC7-4D33-90A8-1EDEE16ECAB7@bjhargrave.com>

BJ Hargrave <bj@bjhargrave.com> writes:

> The test
>
>  invalid_ref "$(printf 'heads/foo\177')"
>
> was added to t1402-check-ref-format.sh. However sh on my RHEL 4 system
> does not handle the DEL (\177) character well in double quoted strings.
>
> sh-3.00$ echo $(printf 'hello\177') | hexdump -C
> 00000000  68 65 6c 6c 6f 7f 0a                              |hello..|
> 00000007
> sh-3.00$ echo "$(printf 'hello\177')" | hexdump -C
> 00000000  68 65 6c 6c 6f 0a                                 |hello.|
> 00000006
>
> The double quotes cause the DEL (\177) character to be discarded.
>
> Can this test be rewritten to avoid this apparent bug in sh on RHEL 4?

For older distros, I would prefer a workaround patch first tested by
distro packaging people and then upstreamed.

Thanks.