From: Junio C Hamano Date: Wed, 09 Nov 2011 13:11:26 GMT Subject: Re: [PATCH] completion: don't leak variable from the prompt into environment Message-ID: <7vd3d1widd.fsf@alter.siamese.dyndns.org> In-Reply-To: <1320832970-26239-1-git-send-email-szeder@ira.uka.de> SZEDER Gábor writes: > Commit e5b8eebc (completion: fix issue with process substitution not > working on Git for Windows, 2011-10-26) introduced a new variable in > __git_ps1_show_upstream(), but didn't declare it as local to prevent > it from leaking into the environment. > --- Thanks; I'd consider this signed-off? > contrib/completion/git-completion.bash | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index b3571ab4..d18895b1 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -110,7 +110,7 @@ __git_ps1_show_upstream () > local upstream=git legacy="" verbose="" > > # get some config options from git-config > - output="$(git config -z --get-regexp '^(svn-remote\..*\.url|bash\.showupstream)$' 2>/dev/null | tr '\0\n' '\n ')" > + local output="$(git config -z --get-regexp '^(svn-remote\..*\.url|bash\.showupstream)$' 2>/dev/null | tr '\0\n' '\n ')" > while read key value; do > case "$key" in > bash.showupstream)