From: Junio C Hamano Date: Thu, 24 Nov 2011 11:50:22 GMT Subject: Re: git-bisect working only from toplevel dir Message-ID: <7vd3chage9.fsf@alter.siamese.dyndns.org> In-Reply-To: <20111124070659.GC6291@m62s10.vlinux.de> Peter Baumann writes: > On Wed, Nov 23, 2011 at 12:45:18PM -0800, Junio C Hamano wrote: > ... >> Also didn't we make bisect workable in a bare repository recently? So the >> start-up sequence has to be something more elaborate like... >> ... >> and then inside bisect_next() you would check if $prefix exists, and go >> there to run bisect--helper (or fail to go there and say "cannot test"). > > But is the "cannot test" aka exit(127) the best we can do in this case? Yeah, thinking about it a bit more, it may probably be better to make it a failure. The user explicitly asked "be in _this_ directory and run make; it should succeed for the bisection test to pass". If the bisection test criterion the user was interested in was a successful build of the whole project (not the subpart of the current directory), the user would have gone up to the top-level and "bisect run make" there.