From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Jan 2012 00:32:26 GMT
Subject: Re: [PATCH v2 3/6] clone: factor out checkout code
Message-ID: <7vd3ascs85.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1326023188-15559-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Read HEAD from disk instead of relying on local variable
> our_head_points_at, so that if earlier code fails to make HEAD
> properly, it'll be detected.

The end result might be more or less the same with your patch from the
end-user's point of view, but "if earlier code fails", shouldn't you
detect and diagnose it right there?

If you observe lack of "HEAD" in checkout(), you cannot tell if that was
because the remote did not have anything usable in the first place, or
because we knew where it should point at (and may have even attempted to
create it) but somehow failed to make it point at it.