From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 17 Feb 2012 15:35:06 GMT
Subject: Re: [PATCH v2] Add a setting to require a filter to be successful
Message-ID: <7vd39dv5g5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F3DFCD0.6070002@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 2/17/2012 2:19, schrieb jehan@orb.com:
>> @@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,
> ...
>>  	ret |= apply_filter(path, src, len, dst, filter);
>> +	if (!ret && required)
>> +		die("required filter '%s' failed", ca.drv->name);
>
> Wouldn't it be much more helpful if this were:
>
> 	die("%s: clean filter '%s' failed", path, ca.drv->name);
>
> Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().
>
>> +	! git checkout -- test.fs
>
> 	test_must_fail git checkout -- test.fs
>
>> +	! git add test.fc
>
> 	test_must_fail git add test.fc
>
> -- Hannes

Thanks; I'll just squash these in in-place.