From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Jul 2012 17:13:33 GMT
Subject: Re: [PATCH v6 4/7] Remove obsolete LONG_USAGE which breaks xgettext
Message-ID: <7vd33jdarm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <6326c11afd7b4077f2aba27101fd9acc8e2f8b6a.1343227806.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

> The obsolete LONG_USAGE variable has the following message in it:
>
>     A'\''--B'\''--C'\''
>
> And such complex LONG_USAGE message will break xgettext when
> extracting l10n messages. But if single quotes are removed from
> the message, xgettext works fine on 'git-rebase.sh'.
>
> Since there is a modern OPTIONS_SPEC variable in use in this
> script, it's safe to remove the obsolete USAGE and LONG_USAGE
> variables.
>
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
> Reviewed-by: Stefano Lattarini <stefano.lattarini@gmail.com>

I've retitled it and swapped the paragraphs around when queuing
this.  LONG_USAGE and USAGE are not just "obsolete" but completely
unused, so they should be removed, even if xgettext did not have a
bug to choke on their contents.

Thanks.