From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 26 Jul 2012 19:07:51 GMT
Subject: Re: [PATCH 2/2] difftool: Handle compare() returning -1
Message-ID: <7vd33i733s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1343282878-86431-2-git-send-email-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

> +sub exit_cleanup
> +{
> +	my ($tmpdir, $status) = @_;
> +	rmtree($tmpdir);
> +	if ($status and $!) {
> +		my ($package, $file, $line) = caller();
> +		warn "$file line $line: $!\n";

Are you sure rmtree() would not clobber $! before the code checks it
here?