From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Sep 2012 05:54:57 GMT
Subject: Re: [PATCH v2 4/5] Integrate wildmatch to git
Message-ID: <7vd31lw5vy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vpq5lw6z8.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Am I missing some includes?
>
> test-wildmatch.c:50: error: array type has incomplete element type
> test-wildmatch.c:52: error: 'POPT_ARG_NONE' undeclared here (not in a function)
> test-wildmatch.c:53: error: 'POPT_ARG_STRING' undeclared here (not in a function)
> test-wildmatch.c:54: error: 'POPT_ARG_INT' undeclared here (not in a function)
> test-wildmatch.c: In function 'main':
> test-wildmatch.c:122: error: 'poptContext' undeclared (first use in this function)
> test-wildmatch.c:122: error: (Each undeclared identifier is reported only once
> test-wildmatch.c:122: error: for each function it appears in.)
> test-wildmatch.c:122: error: expected ';' before 'pc'
> cc1: warnings being treated as errors
> test-wildmatch.c:125: error: implicit declaration of function 'poptGetNextOpt'
> test-wildmatch.c:125: error: 'pc' undeclared (first use in this function)
> test-wildmatch.c:128: error: implicit declaration of function 'poptGetOptArg'
> test-wildmatch.c:139: error: implicit declaration of function 'poptBadOption'
> test-wildmatch.c:139: error: 'POPT_BADOPTION_NOALIAS' undeclared (first use in this function)
> test-wildmatch.c:140: error: implicit declaration of function 'poptStrerror'
> test-wildmatch.c:148: error: implicit declaration of function 'poptGetArgs'

Yeah, popt.h it is.  It is a bit distasteful that we have a build
dependency only to build test-* helper on something that we do not
even have runtime dependency on.