From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Feb 2013 20:23:00 GMT
Subject: Re: [PATCH] Add contrib/credentials/netrc with GPG support, try #2
Message-ID: <7vd2wese6z.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87bobyr0ju.fsf@lifelogs.com>

Ted Zlatanov <tzz@lifelogs.com> writes:

> JCH> You still need to parse a file that has a "default" entry correctly;
> JCH> otherwise the users won't be able to share existing .netrc files
> JCH> with other applications e.g. ftp, which is the whole point of this
> JCH> series.  Not using values from the "default" entry is probably fine,
> JCH> though.
>
> OK; done in PATCHv4.

Hmph.

Didn't you remove that from your version of net_netrc_loader when
you borrowed the bulk of the code from Net::Netrc::_readrc?  I see
"default" token handled at the beginning of "TOKEN: while (@tok)"
loop in the original but not in your version I see in v4.