From: Junio C Hamano Date: Mon, 18 Feb 2013 09:40:17 GMT Subject: Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet Message-ID: <7vd2vyarjy.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130218092221.GD5096@sigill.intra.peff.net> Jeff King writes: > I'm really tempted to bump all of our 1000-byte buffers to just use > LARGE_PACKET_MAX. If we provided a packet_read variant that used a > static buffer (which is fine for all but one or two callers), then it > would not take much memory... I thought that 1000-byte limit was kept when we introduced the 64k interface to interoperate with other side that does not yet support the 64k interface. Is your justification that such an old version of Git no longer matters in the real world (which is true, I think), or we use 1000-byte limit in some codepaths even when we know that we are talking with a 64k-capable version of Git on the other side?