From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 19 Apr 2013 18:54:23 GMT
Subject: Re: [PATCH] stash: tighten IS_STASH_LIKE logic
Message-ID: <7vd2tq1hcw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0maM5ocSoSGy8OdL+hNW9mm_s1m1h+xJeCq-JKfTMW0Uw@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Junio C Hamano wrote:
>> The risk of actually closing the door for future developers.  That
>> is a downside of this patch, if we were to apply it.
>
> Okay, no issues.  Drop it.
>
> Consider documenting the fact that IS_STASH_LIKE is merely a
> contextual synonym for IS_MERGE_COMMIT somewhere though.

Documenting what IS_STASH_LIKE means and what it is meant to be used
for would add a lot of value, if it is not done already, but I doubt
it adds much value to document that it _happens to be implemented_
as "is it a merge commit?" in the current version.