From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 15 May 2013 19:13:26 GMT
Subject: Re: Lines missing from git diff-tree -p -c output?
Message-ID: <7vd2ssawfd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130515181734.GT25742@login.drsnuggles.stderr.nl>

Matthijs Kooijman <matthijs@stdin.nl> writes:

>> Could you explain why you think it hides the real problem, and what
>> kind of future enhancement may break it?
> I think the differences is mostly in the locality of the fix. In my
> proposed patch, the no_pre_delete flag is never set on an interesting
> line because it is checked in the line before it. In your patch, it
> never happens because the control flow guarantees the "context" lines
> before each change must be uninteresting.
>
> The net effect is of course identical, but I'm arguing that depending on
> the control flow and some code a doze lines down is easier to break than
> depending on a previous line.

Yeah, that sounds like a reasonable reasoning.