From: Junio C Hamano Date: Sun, 22 May 2005 19:15:05 GMT Subject: Re: [PATCH] The diff-raw format updates. Message-ID: <7vbr73dqdi.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20050522183645.GA1866@localhost.localdomain> >>>>> "NH" == Niklas Hoglund writes: NH> On Sun, May 22, 2005 at 11:35:34AM -0700, Linus Torvalds wrote: >> :000000 100644 0000000000000000000000000000000000000000 25ab9eda939ad92bb746c2419d083b1e52117a56 diffcore-pathspec.c diffcore-pathspec.c NH> Don't you think it would be easier to read if the SHA1 field was, say, a NH> dash and 19 spaces, instead of an obviously bogus SHA1? My understanding of the purpose of the diff-raw format is primarily about machine readablility; 0{40} was far easier to code cleanly---please see why in diff-helper.c.