From: Junio C Hamano <junkio@cox.net>
Date: Sun, 29 Jan 2006 20:15:27 GMT
Subject: Re: [PATCH] rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>
Message-ID: <7vbqxukcyo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060129134056.GA3428@Muzzle>

Eric Wong <normalperson@yhbt.net> writes:

> Both -n<n> and -n <n> are supported.  POSIX versions of head(1) and
> tail(1) allow their line limits to be parsed this way.  I find
> --max-count to be a commonly used option, and also similar in spirit to
> head/tail, so I decided to make life easier on my worn out (and lazy :)
> fingers with this patch.

I agree with this in principle.

> diff --git a/rev-parse.c b/rev-parse.c
> index 7abad35..3790463 100644
> --- a/rev-parse.c
> +++ b/rev-parse.c
> @@ -21,6 +21,7 @@ static char *def = NULL;
>  static int show_type = NORMAL;
>  static int symbolic = 0;
>  static int output_sq = 0;
> +static int next_arg_is_rev = 0;

Do you need this here, or can it be made auto in main()?