From: Junio C Hamano Date: Wed, 08 Nov 2006 07:59:17 GMT Subject: Re: What's in git.git Message-ID: <7vbqniv06i.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Jakub Narebski writes: > Junio C Hamano wrote: > >>    Jakub Narebski (4): > [...] >>       gitweb: Output also empty patches in "commitdiff" view > > I think that this patch is a bit premature. Without "new improved patchset > view" the empty patches are just that: totally empty. It is new header and > especially outputting extended header information which makes outputting > "empty" patches (with no diff) in "commitdiff" view usefull. By "empty" > patches I mean pure type change, pure rename, pure copy and type change and > rename. > > The "new improved patchset view" is prepared to send in two stages... At least this does not break the page even without these two follow-ups. If the follow-ups come in time and do not break the page, they are very welcome post -rc1 fixes to have before the final release. On the other hand, even if they don't, it's not the end of the world ;-).