From: Junio C Hamano <junkio@cox.net>
Date: Sun, 22 Apr 2007 02:15:09 GMT
Subject: Re: [PATCH 4/4] Add 'filter' attribute and external filter driver definition.
Message-ID: <7vbqhhrw7m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070422003929.GD17480@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> ick.  What about something like this on top?  I moved the extra child
> process for the input pipe down into the start_command routine,
> where we can do something a little smarter on some systems, like
> using a thread rather than a full process.  Its also a shorter
> patch and uses more of the run-command API.

Well, I did not like start_command() that wanted to always
perform the full exec of something else for its inflexibility,
and this piles a specific hack on top of it...  Why not a
callback with void * pointer?

Or are you trying to make this interface as inflexible and
feature-limited as possible, perhaps to make it easier to
porting to Windows?