From: Junio C Hamano Date: Sun, 25 Nov 2007 22:29:07 GMT Subject: Re: [Resend Trivial PATCH] For the sake of correctness, fix file descriptor leak. Message-ID: <7vbq9ij6x8.fsf@gitster.siamese.dyndns.org> In-Reply-To: The codepath you are touching will exit immediately after an error return; I do not feel much urgency to it, although I do not think the patch would _hurt_. Please follow the established convention for patch submission (see patches on the list from other people as examples).