From: Junio C Hamano Date: Thu, 31 Jan 2008 10:38:37 GMT Subject: Re: git-push: forced update of tag shows unabbreviated SHA1 Message-ID: <7vbq72cmaa.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080131102716.GC25546@coredump.intra.peff.net> Jeff King writes: > On Thu, Jan 31, 2008 at 05:06:25AM -0500, Jeff King wrote: > >> But getting back to your point: yes, I agree it is a little ugly. >> Rewriting find_unique_abbrev would be necessary for fixing it, and I'm >> not sure it is worth the trouble. > > Actually, it looks like we already handle a similar case: the null sha1, > so the change isn't that big (and the null sha1 case folds nicely into > the "missing" case). Heh, "Make sure to abbreviate something that does not match" --- I forgot about that trick I did looooooooong time ago ;-). I like the idea. Does it not break anything?