From: Junio C Hamano Date: Sun, 24 Feb 2008 08:42:26 GMT Subject: Re: [PATCH] parse-opt: bring PARSE_OPT_HIDDEN to git-rev-parse --parseopt Message-ID: <7vbq66ycct.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080223140926.GD10967@artemis.madism.org> Pierre Habouzit writes: > I also made the parsing more extensible wrt new flags if needed. > > We should definitely write tests too. > ... > + case '*': > + o->flags &= PARSE_OPT_HIDDEN; > + break; I have a slight suspicion that this is not what you meant. You probably meant either |= or perhaps ^=.