From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Feb 2008 07:16:30 GMT
Subject: Re: [PATCH 1/3] help: use parseopt
Message-ID: <7vbq65o69d.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080225065710.GA3765@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Feb 25, 2008 at 07:50:52AM +0100, Christian Couder wrote:
>
>> > Sorry, the diff turned out quite messy because of the cleanups. It's
>> > probably easier to just read the result.
>> 
>> Or could you send the cleanups in some separated patches ?
>
> Looking at it again, it's actually not too bad except for the cmd_help()
> function itself, which isn't due to the cleanups at all, but because the
> flow changes quite a bit. So I don't think splitting it actually will
> make the diff any friendlier.

Your patch is fine as-is.