From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 06 Jul 2008 00:57:28 GMT
Subject: Re: [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c
Message-ID: <7vbq1brfrb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080705204849.GJ4729@genesis.frugalware.org>

Miklos Vajna <vmiklos@frugalware.org> writes:

> I think it's fine to move such a function, but this is a false commit
> message, you can use read_revisions_from_stdin() from builtin-bundle if
> it lives in builtin-rev-list.c as well.

At the mechanical level, yes you _can_, but it is simply a bad taste to do
so.  More library-ish files such as revision.c are better home for utility
functions to be shared between builtins and commands.