From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 06 Aug 2008 15:31:13 GMT
Subject: Re: [BUG] git diff-tree --stdin doesn't accept two trees
Message-ID: <7vbq06rwhq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080806115358.GD18336@diana.vm.bytemark.co.uk>

Karl Hasselström <kha@treskal.com> writes:

>> The feature of --stdin to take a commit and its parents on one line was
>> broken before that to support the common
>>
>>         rev-list --parents $commits... -- $paths... |
>>                 diff-tree --stdin -v -p
>>
>> usage pattern by Porcelains.  For diff-tree to talk sensibly about
>> commits, it needs to see commits, not just trees.
>
> But is there any fundamental reason why it couldn't accept tree-ishes
> as well?

The -v option given to diff-tree is the key.  Without it, it could take
trees.