From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Nov 2008 19:57:53 GMT
Subject: Re: [PATCH] git-diff: Add --staged as a synonym for --cached.
Message-ID: <7vbpwkogxq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081112193747.GA21567@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I'm not sure I agree. They _are_ different things, but in the case of
> diff, you are really treating each of them like a tree (which makes
> range operators a little silly, but then that is a silliness already
> present in "git diff tree1..tree2").

It is not _little_ silly, but quite silly.  It is a historical accident
and I personally suggest against using it when I teach git to others.

And we are _not_ treating each of them like a tree.  We might be treating
them as collection of paths (and the range operator is about commits).

> But again, I would not be convinced this is a good direction until I
> saw:
> ...
> And I'm still not volunteering to work on it, so somebody else will have
> to come up with those things. ;)

Even if they would, I do not think it is a good direction to go.  It makes
the UI less intuitive and harder to learn.