From: Junio C Hamano Date: Wed, 28 Jan 2009 01:47:17 GMT Subject: Re: [PATCH] send-pack: Filter unknown commits from alternates of the remote Message-ID: <7vbptsyzfe.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20090128013840.GA7224@atjola.homenet> Björn Steinbrink writes: > Since 40c155ff14c, receive-pack on the remote also sends refs from its > alternates. Unfortunately, we don't filter commits that don't exist in the > local repository from that list. This made us pass those unknown commits > to pack-objects, causing it to fail with a "bad object" error. Yeah, it is a step in the right direction, but is the *wrong* fix I described in my previous message. Our mails crossed ;-) And I think we should have this in the place where we receive .have, i.e. inside add_extra_have() in connect.c