From: Junio C Hamano Date: Tue, 20 Oct 2009 16:55:11 GMT Subject: Re: [PATCH] blame: make sure that the last line ends in an LF Message-ID: <7vbpk2ovio.fsf@alter.siamese.dyndns.org> In-Reply-To: Sverre Rabbelier writes: >> Does the code assign blame >> correctly around the last line of the original blob? > > Yes, it does,... That is kind of surprising ;-) as I do remember that I never thought about this issue of dealing with the incomplete lines while writing the blame algorithm. I actually didn't even think about "well this will not work because I am ignoring the incomplete lines". >> Or am I worrying too much? > > No, I think your concerns are valid, we should go with (2) and DTRT. > Does the updated patch address your concerns? If so I can send a new > version. Assuming the internal blame algorithm correctly works with such an input, I'd be happier with an approach to allow users to tell the difference. The --porcelain output was designed to be extensible, and it might make sense to show the "this line is incomplete" as a separate bit, though.