From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Nov 2009 00:47:07 GMT
Subject: Re: [PATCH] commit -c/-C/--amend: acquire authorship and restamp time with --claim
Message-ID: <7vbpjlycqc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <55bacdd30911011257m22ee85f2wc5d51865f7f2aadd@mail.gmail.com>

Erick Mattos <erick.mattos@gmail.com> writes:

>>    % git commit --claim --author='Erick Mattos <eric@mattos>' -C HEAD
>>
>> Should you detect an error?  Does your code do so?  Do you have a test
>> that catches this error?
>
> It works as intended.  Both together.

That does not make any sense.  If you are saying this is yours and it is
his at the same time, there can be no sane way to work "as intended", no?.

>>> +     git commit -c HEAD <<EOF
>>> +     "Changed"
>>> +     EOF &&
>>
>> What editor is reading this "Changed"?
>
> Nobody cares...  Just a text to change the file.

I actually care.  Who uses that Changed string, and where does it end up
with?  At the end of the log message?  At the beginning?  What "file"?