From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 May 2011 05:09:58 GMT
Subject: Re: [PATCH] add-interactive: shortcut to add hunk and quit
Message-ID: <7vboz1j4k9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpq4o4uwqin.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Hermann Gausterer <git-mailinglist@mrq1.org> writes:
>
>> this combines the two commands "y"+"q" to one.
>> i use this if i know that this is the last hunk to add.
>
> (please capitalize the "I", and actually, avoid saying "I" in a commit
> message)
>
> I'm not convinced this is useful enough to deserve a new command. The
> help message already starts being scary ...
>
>> +       Q - quit; stage this hunk but none of the remaining ones
>
> The explanation shouldn't start with "quit" I think. I'd say basically
> "stage this hunk and quit" or "stage this hunk but none of the remaining
> ones".

I agree with both points. Other than that, the changes in this round looks
good to me.

Hermann, care to re-roll for the last time?