From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Jun 2011 22:30:56 GMT
Subject: Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN
Message-ID: <7vboxsb0f3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110620220027.GD32765@one.firstfloor.org>

Andi Kleen <andi@firstfloor.org> writes:

>> I would need to clarify with s/introduce noise/introduce more noise/; the
>> existing codebase is not noise-free.
>> 
>> But I do not see much point in making things worse, only to squelch
>> "reaches end of non void function" warnings that will be given under the
>> NO_NORETURN workaround configuration.
>
> Can you please give specific guidance what I should do to make
> the patchkit acceptable?

I am inclined to apply only 1 and 3, which is what I already have on 'pu'.