From: Junio C Hamano Date: Tue, 20 Sep 2011 00:41:07 GMT Subject: Re: [PATCH] git-mergetool: check return value from read Message-ID: <7vboug82qk.fsf@alter.siamese.dyndns.org> In-Reply-To: <1316475652-35188-1-git-send-email-jaysoffian@gmail.com> Jay Soffian writes: >> I suspect that it would be more consistent with 6b44577 (mergetool: check >> return value from read, 2011-07-01), which this patch is a follow-up to, >> to do: >> >> read answer || return 1 >> >> here. > > Thanks, sorry I missed that. Thank _you_ for spotting these unchecked "read"s. Will queue.