From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Apr 2012 17:57:42 GMT
Subject: Re: [PATCH 1/5] t1507: add additional tests for @{upstream}
Message-ID: <7vbomykv6x.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vfwcakvfw.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
>
>> +error_message () {
>> +	(cd clone &&
>> +	 test_must_fail git rev-parse --verify "$@")
>> +}
>> ...
>> +test_expect_success 'branch@{u} error message when no upstream' '
>> +	cat >expect <<-EOF &&
>> +	error: No upstream branch found for ${sq}non-tracking${sq}
>> +	fatal: Needed a single revision
>> +	EOF
>> +	(cd clone &&
>> +	 test_must_fail git rev-parse --verify non-tracking@{u}) 2>actual &&
>
> Why not use "error_message" as other new tests?

I think the remainder of the message should be ignored.  Will comment on
individual steps.

Thanks.