From: Junio C Hamano Date: Sun, 06 Jan 2013 20:00:51 GMT Subject: Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Message-ID: <7vbod2nkss.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130106143319.GA10690@sigill.intra.peff.net> Jeff King writes: > On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > >> Windows disallows file names that contain a star. Arrange the test setup >> to insert the file name "f*" in the repository without the corresponding >> file in the worktree. >> [...] >> - test_commit star "f*" && >> + # insert file "f*" in the commit, but in a way that avoids >> + # the name "f*" in the worktree, because it is not allowed >> + # on Windows (the tests below do not depend on the presence >> + # of the file in the worktree) >> + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && >> + test_tick && >> + git commit -m star && > > Thanks, looks obviously correct to me. > > Sorry to break Windows again. It seems I learn about a new gotcha with > every patch series. :) Thanks, both. It appears that pushing things earlier to 'next' (and unfortunately even to 'master') rather than later seems to be the only way to help catching little gotchas like this ;-). -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en