From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Apr 2013 18:03:44 GMT
Subject: Re: [PATCH v2 4/5] check-ignore: allow incremental streaming of queries via --stdin
Message-ID: <7vbo96phmn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130411203141.GB21091@pacific.linksys.moosehall>

Adam Spiers <git@adamspiers.org> writes:

> On Thu, Apr 11, 2013 at 03:11:32PM -0400, Jeff King wrote:
>> I always get a little nervous with sleeps in the test suite, as they are
>> indicative that we are trying to avoid some race condition, which means
>> that the test can fail when the system is under load, or when a tool
>> like valgrind is used which drastically alters the timing (e.g., if
>> check-ignore takes longer than 1 second to produce its answer, we may
>> fail here).
>
> Agreed, especially here where my btrfs filesystems see fit to kindly
> freeze my system for a few seconds many times each day :-/
> 
>> Is there a simpler way to test this?
>> 
>> Like:
>> ...
> I'll re-roll using your approach.

I think I missed this one and it already is in 'next'.

I'll hold it back so please make your re-roll into an incremental
update.

Thanks.