From: Junio C Hamano Date: Tue, 14 May 2013 21:40:53 GMT Subject: Re: [PATCH v3 09/10] remote-hg: test: be a little more quiet Message-ID: <7vbo8dgryy.fsf@alter.siamese.dyndns.org> In-Reply-To: <51929e298955c_13a8f89e18228b@nysa.mail> Felipe Contreras writes: > No-brainer; improve one test. In general, unless we are taking the output from commands to a file and grepping in it, we prefer not to have --quiet (unless you are testing the --quiet feature of the command, of course). Running the tests without "-v" option will not show them and when running with "-v" to debug the tests, the extra output will help to figure out which step failed. > Felipe Contreras wrote: >> Signed-off-by: Felipe Contreras >> --- >> contrib/remote-helpers/test-hg.sh | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh >> index 8de2aa7..f8d1f9e 100755 >> --- a/contrib/remote-helpers/test-hg.sh >> +++ b/contrib/remote-helpers/test-hg.sh >> @@ -109,10 +109,10 @@ test_expect_success 'update bookmark' ' >> ( >> git clone "hg::$PWD/hgrepo" gitrepo && >> cd gitrepo && >> - git checkout devel && >> + git checkout --quiet devel && >> echo devel > content && >> git commit -a -m devel && >> - git push >> + git push --quiet >> ) && >> >> hg -R hgrepo bookmarks | egrep "devel[ ]+3:" >> -- >> 1.8.3.rc1.579.g184e698