From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 May 2013 16:28:31 GMT
Subject: Re: [PATCH] completion: trivial fix for zsh
Message-ID: <7vbo84qouo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s04oKBtjnF-+5hjPM+-krZA=m-4=Mb=vzU65GsTNhR3vA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Mon, May 20, 2013 at 7:33 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> zsh completion wrapper doesn't reimplement __gitcompadd(). Although it
>> should be trivial to do that, let's use __gitcomp_nl() which achieves
>> exactly the same thing, specially since the suffix ($4) has to be empty.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> This is probably v1.8.3 material, I just noticed it's probably a
> regression introduced by 1ce23aa (completion: add new __gitcompadd
> helper).

Great.  That is not in v1.8.2.X, but was already in v1.8.3-rc0, so
we would need to do something about it.

I am not very happy about the latter "probably", though.  If it is a
regression, at this late in the cycle, it is often safer to revert
the original.

Will apply directly to 'master'.  Thanks.