From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Jun 2013 23:00:40 GMT
Subject: Re: [PATCH 13/16] repack: consider bitmaps when performing repacks
Message-ID: <7vbo6tztgn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1372116193-32762-14-git-send-email-tanoku@gmail.com>

Vicent Marti <tanoku@gmail.com> writes:

> @@ -156,6 +156,11 @@ do
>  	fullbases="$fullbases pack-$name"
>  	chmod a-w "$PACKTMP-$name.pack"
>  	chmod a-w "$PACKTMP-$name.idx"
> +
> +	test -f "$PACKTMP-$name.bitmap" &&
> +	chmod a-w "$PACKTMP-$name.bitmap" &&
> +	mv -f "$PACKTMP-$name.bitmap" "$PACKDIR/pack-$name.bitmap"

If we see a temporary bitmap but somehow failed to move it to the
final name, should we _ignore_ that error, or should we die, like
the next two lines do?

>  	mv -f "$PACKTMP-$name.pack" "$PACKDIR/pack-$name.pack" &&
>  	mv -f "$PACKTMP-$name.idx"  "$PACKDIR/pack-$name.idx" ||
>  	exit