From: Junio C Hamano Date: Tue, 23 May 2006 08:41:52 GMT Subject: Re: Make more commands builtin Message-ID: <7vac995e0f.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <35036.1277036884$1148372628@news.gmane.org> "Peter Eriksen" writes: > Makefile | 26 +++++++++++++++----------- > apply.c => builtin-apply.c | 3 ++- > commit-tree.c => builtin-commit-tree.c | 3 ++- > diff-files.c => builtin-diff-files.c | 3 ++- > diff-index.c => builtin-diff-index.c | 3 ++- > diff-stages.c => builtin-diff-stages.c | 3 ++- > diff-tree.c => builtin-diff-tree.c | 3 ++- > ls-files.c => builtin-ls-files.c | 3 ++- > ls-tree.c => builtin-ls-tree.c | 3 ++- > read-tree.c => builtin-read-tree.c | 3 ++- > show-branch.c => builtin-show-branch.c | 3 ++- > tar-tree.c => builtin-tar-tree.c | 3 ++- > builtin.h | 12 ++++++++++++ > git.c | 13 ++++++++++++- > > I've tried to follow the trend of making commands builtin. > All patches have the same form. This is my first use > of git-send-email, so this might come out wrong. > > Peter Eriksen Was this intentional? Reply-To: Patches/@bohr.gbar.dtu.dk Reply-To: Patches/0001-Builtin-git-ls-files.txt@bohr.gbar.dtu.dk Otherwise the form looks OK, except that with this particular series, I would have much preferred to see these with "format-patch -M"; it is really hard to review otherwise. BTW, I already have tar-tree built-in in "next" branch. I'll go to bed now, so please expect review Ack/Nack until evening my time (it is 01:40 here) from me.