From: Junio C Hamano <junkio@cox.net>
Date: Thu, 24 Aug 2006 07:36:52 GMT
Subject: Re: [RFC] adding support for md5
Message-ID: <7vac5ubn57.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060823064900.GA26340@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

>> > What about all of those memcpy(a, b, 20)'s?  :-)
>> 
>> Surely.  If you are inclined to, go wild.
>
> Like this?  :-)

Except some minor nits, yes.

 * I would have preferred two patches, one for "master" and one
   for the C merge-recursive topic (or at least "next").

 * You missed a few in "master".

 * The cast in the second hunk in combine-diff.c was wrong;
   breakage was caught by our testsuite.

I've pushed out a fixed up result in "master" and "next".