From: Junio C Hamano Date: Wed, 21 Feb 2007 09:21:34 GMT Subject: Re: [PATCH 1.5.0.1.37] fix git-remote inconsistent about use of dots in remote names Message-ID: <7vabz7sw69.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20070221085422.GF23952@jukie.net> This is what I have currently queued -- please see earlier discussion with Pavel on the list. -- >8 -- From: Pavel Roskin Date: Wed, 21 Feb 2007 00:03:36 -0500 Subject: [PATCH] git-remote: support remotes with a dot in the name [jc: the original from Pavel was limiting the variable names to only fetch and url, but I loosened it to take valid variable names.] Signed-off-by: Pavel Roskin Signed-off-by: Junio C Hamano --- git-remote.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index 61244e9..bd70bf1 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -67,7 +67,7 @@ sub list_remote { $git->command(qw(config --get-regexp), '^remote\.'); }; for (@remotes) { - if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) { + if (/^remote\.(\S+?)\.([^.\s]+)\s+(.*)$/) { add_remote_config(\%seen, $1, $2, $3); } } -- 1.5.0.1.587.g8493