From: Junio C Hamano <junkio@cox.net>
Date: Thu, 08 Mar 2007 10:22:37 GMT
Subject: Re: [PATCH, nitpickingly final version] git-branch, git-checkout: autosetup for remote branch tracking
Message-ID: <7vabyo9gr6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <45EFDE4B.3010408@lu.unisi.ch>

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> 	This fixes all the nits you pointed out. :-D
> 	Now, this was an experience to make...

Thanks.

Will apply after reviewing once more tomorrow, with fix-ups
locally if needed.  No need to resend.

> +
> +	colon = strchr(value, ':');
> +        if (!colon)

s/^\040{8}/\011/;

> diff --git a/trace.c b/trace.c
> index 27fef86..27b2e85 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -41,13 +41,15 @@ static in...
> +int nfasprintf(char **str, const char *fmt, ...)
>  {
> +	int rc;
> +	va_list args;
> +
> +	va_start(args, fmt);
> +	rc = nfvasprintf(str, fmt, args);
> +	va_end(args);
> +	return args;
>  }

s/return args/return rc/;