From: Junio C Hamano <junkio@cox.net>
Date: Thu, 05 Apr 2007 05:39:11 GMT
Subject: Re: [PATCH] Makefile: Add '+' to QUIET_SUBDIR0 to fix parallel make.
Message-ID: <7vabxnwfb4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070404204233.GA14252@ferdyx.org>

"Fernando J. Pereda" <ferdy@gentoo.org> writes:

> Signed-off-by: Fernando J. Pereda <ferdy@gentoo.org>
> ---
>
>   I don't know if this breaks non-gnu make, and don't have an easy way
>   to test it right now. So someone should do that before it is applied.

I had an impression that our makefile is quite dependent on GNU
make already.  Do people build git without gmake?

>   This is needed for GNU make to let sub-makes connect to the jobserver
>   when multiple jobs are specified (-j option to make). It was not
>   needed before 74f2b2a8d006a49e1be7e30731c2f7365d2741d1 because of how
>   GNU make works.

Thanks.  The info page does not talk about -j but '+' apparently
is needed for jobserver.

       As a special feature, using the variable `MAKE' in the commands of a
    rule alters the effects of the `-t' (`--touch'), `-n' (`--just-print'),
    or `-q' (`--question') option.  Using the `MAKE' variable has the same
    effect as using a `+' character at the beginning of the command line.
    *Note Instead of Executing the Commands: Instead of Execution.  This
    special feature is only enabled if the `MAKE' variable appears directly
    in the command script: it does not apply if the `MAKE' variable is
    referenced through expansion of another variable.  In the latter case
    you must use the `+' token to get these special effects.